Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our application, we sometimes need to embed Javascript variables:
However, in order to do this, we've had to call
JSON.stringify
from the calling code before rendering the template:It's easy to forget which variables must be stringified, and which shouldn't be. This is because mustache is designed to emit HTML. However, JS is such an integral part of HTML, it deserves its own emitting mode.
Additionally, JSON.stringify actually can't even be relied upon to emit correct JS (http://timelessrepo.com/json-isnt-a-javascript-subset). The string
JSON.stringify('\u2028')
, for instance, is an invalid JS string, because it contains a line separator.This commit implements a new filter which will emit JS. The above template would be written:
The
js&
tag was chosen arbitrarily. Any other tag would work just as well.