Document the API #542
Merged
Document the API #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documenting the vanilla JS API in the readme is a a nice addition. 👍 |
| Mustache.render( | ||
| template : String, | ||
| view : Object, | ||
| partials : Object, |
There was a problem hiding this comment.
partials should be marked as optional.
|
Thanks! Although I don't know much about rtype, it LGTM other than my inline comment. |
|
🏁 |
|
Awesome quickfix! Last nitpick would be if you could please squash these On Monday, 22 February 2016, Tomek Wiszniewski notifications@github.com
|
I couldn’t find the API in the docs. This is what I found out by reading the source. Let’s save others the pain. Mark partials as optional
tomek-he-him
force-pushed
the
api-docs
branch
from
60fefb0
to
119b504
Compare
|
There ya go! |
|
👍 |
This was referenced Mar 17, 2020
This was referenced Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn’t find the API in the docs. This is what I found out by reading the source. Let’s save others the pain.