Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the API #542

Merged
merged 1 commit into from
Feb 24, 2016
Merged

Document the API #542

merged 1 commit into from
Feb 24, 2016

Conversation

tomek-he-him
Copy link
Contributor

I couldn’t find the API in the docs. This is what I found out by reading the source. Let’s save others the pain.

@Siilwyn
Copy link

Siilwyn commented Feb 6, 2016

Documenting the vanilla JS API in the readme is a a nice addition. 👍

Mustache.render(
template : String,
view : Object,
partials : Object,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partials should be marked as optional.

@phillipj
Copy link
Collaborator

Thanks! Although I don't know much about rtype, it LGTM other than my inline comment.

@tomek-he-him
Copy link
Contributor Author

🏁

@phillipj
Copy link
Collaborator

Awesome quickfix! Last nitpick would be if you could please squash these
two commits, then I'll merge it first thing tomorrow.

On Monday, 22 February 2016, Tomek Wiszniewski notifications@github.com
wrote:

[image: 🏁]


Reply to this email directly or view it on GitHub
#542 (comment).

I couldn’t find the API in the docs. This is what I found out by reading the source. Let’s save others the pain.

Mark partials as optional
@tomek-he-him
Copy link
Contributor Author

There ya go!

phillipj added a commit that referenced this pull request Feb 24, 2016
@phillipj phillipj merged commit 85bccf6 into janl:master Feb 24, 2016
@phillipj
Copy link
Collaborator

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants