-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assert null lookup when rendering an unescaped value #553
Conversation
Gonna try placing the new assertion in a more adequate test file. |
c7a97ee
to
22b7515
Compare
Either vim or git was going crazy with the indentation when I tried improving the test via changing one of the lines, so I linted it all together.
It was not being asserted anywhere else, and I was suspecting that PR #552 was changing current (and correct) behaviour.
22b7515
to
7e83df9
Compare
Waiting for confirmation from @bobthecow, just in case: https://twitter.com/dasilvacontin/status/709796886568423424. |
This is probably in the category of things — like the definition of "falsey" — that is up to the individual library to decide what best fits in the host language. In my opinion the JavaScripty thing to do when encountering a Note that At the very least, if I'm wrong it'd be a backwards compatibility break, so it's not allowed until the next major release :) |
Thanks for your insight! We are doing both things – great! 😄. We treat
|
👍 sgtm |
286ad64
to
7e83df9
Compare
It was not being asserted anywhere else, and I was suspecting that
PR #552 was changing current (and correct) behaviour.