Pass context.view to partials function #619
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing 馃憤 This sounds good to me. Could you add a test ensuring this works as intended? |
|
Sure thing! Busy tonight but will do this tomorrow |
|
Sorry for the delay, got caught up with other things. I noticed while trying to add a test that there was no check for retrieving partials using a function rather than an object, so that's what the test I wrote ensures. To do so however, I had to modify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This idea arose from a project that I'm working on where I need to handle the logic for loading my own partials. This is because there might be hundreds of partials and I don't want to load all of them into memory (AKA using a partials object).
From parsing through the source code, I saw that the
partialsparameter forrenderPartialcan be a function. Great! However, when rendering through a function, I also need access to the context for the partial and currently, only the name of the partial is provided. This is where this PR comes is 馃槃.