Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug: cache actually not working #664

Merged
merged 1 commit into from
Jul 27, 2018
Merged

fix bug: cache actually not working #664

merged 1 commit into from
Jul 27, 2018

Conversation

aruku7230
Copy link
Contributor

Resolve issue #663 and add test.

phillipj
phillipj approved these changes Jul 27, 2018
View reviewed changes
Copy link
Collaborator

@phillipj phillipj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for your contribution, with much appreciated test 👍

@phillipj phillipj merged commit 28ca619 into janl:master Jul 27, 2018
@phillipj phillipj mentioned this pull request Aug 8, 2018
Merged
This was referenced Aug 15, 2018
Closed
Merged
Closed
phillipj pushed a commit that referenced this pull request Aug 17, 2018
@raymond-lam @phillipj
Fix custom tags by rolling back #643 & #664 (#670)
5acafd3 
Pull requests #643 and #664 together fix the issue reported in issue #617, but the change in behavior is causing semvers concerns. See issue #669. Therefore, roll back #643 and #664 and later reintroduce in next planned major release (v3.0).

Fixes #669
phillipj pushed a commit that referenced this pull request Aug 25, 2018
@raymond-lam @phillipj
Reintroduce pull requests #643 and #664, and update description for
7845848 
parse method
@Leko Leko mentioned this pull request Sep 18, 2018
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 18, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Jan 6, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 3, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 24, 2020
Merged
This was referenced Mar 17, 2020
Merged
Merged
Merged
This was referenced Mar 27, 2020
Open
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 5, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 15, 2020
Open
This was referenced Apr 23, 2020
Open
Open
Closed
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipj phillipj phillipj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aruku7230 @phillipj