Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: cache actually not working #664

Merged
merged 1 commit into from
Jul 27, 2018
Merged

fix bug: cache actually not working #664

merged 1 commit into from
Jul 27, 2018

Conversation

aruku7230
Copy link
Contributor

Resolve issue #663 and add test.

Copy link
Collaborator

@phillipj phillipj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for your contribution, with much appreciated test 👍

@phillipj phillipj merged commit 28ca619 into janl:master Jul 27, 2018
phillipj pushed a commit that referenced this pull request Aug 17, 2018
Pull requests #643 and #664 together fix the issue reported in issue #617, but the change in behavior is causing semvers concerns. See issue #669. Therefore, roll back #643 and #664 and later reintroduce in next planned major release (v3.0).

Fixes #669
phillipj pushed a commit that referenced this pull request Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants