Install release tools with npm rather than via pre-commit hook #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously mocha, uglifyjs and jshint used when publishing a new version were ensured / installed by `Rakefile` via the pre-commit git hook. Those modules were automatically installed globally if not present in `$PATH`. Installing modules globally has one particular dowsides that we should avoid: we can't ensure developers publishing new mustache.js versions have the same version of these 3rd party modules installed. If instead we make these modules local dev dependencies, we can ensure which versions are installed, and we make 3rd party depedencies explicit by listing them in `package.json`, rather than in `Rakefile`.
|
@dasilvacontin if you remember any particular reason we've avoided installing these modules via npm before, please share :) |
phillipj
added a commit
that referenced
this pull request
Aug 7, 2018
Previously when replacing dependency installation with `npm` rather than `rake`, there were still install task references found in `Rakefile` which should have been removed as well. ``` $ npm version patch v2.3.1 ... npm ERR! > minifying `mustache.js`... npm ERR! rake aborted! npm ERR! Don't know how to build task 'install_uglify' ``` Those `install_*` tasks does not exist anymore, as installing those dependencies are done with npm now. Refs #666
This was referenced Mar 17, 2020
This was referenced Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for publish a couple of new versions of mustache.js, I stumbled upon a couple of improvements.
Previously mocha, uglifyjs and jshint used when publishing a new version were ensured / installed by
Rakefilevia the pre-commit git hook. Those modules were automatically installed globally if not present in$PATH.Installing modules globally has one particular downside that we should avoid: we can't ensure developers publishing new mustache.js versions have the same version of these 3rd party modules installed.
If instead we make these modules local dev dependencies, we can ensure which versions are installed, and we make 3rd party dependencies explicit by listing them in
package.json, rather than inRakefile.