-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #429 - support .js views with functions. #717
Conversation
Thanks a lot for this contribution! 💯 Any plans or thoughts for testing this? It's important we know this works as expected, both currently and going forward when doing future improvements. |
I should be able to make that happen. Since #429 referenced having an issue with the bold example in the readme section that sounds like a good test to start with. |
Tests janl#717 for cli which allows use of functions in a view which is exported javascript.
Great getting a test in place 👍 Other than a naming nitpick, this LGTM. |
Co-Authored-By: Phillip Johnsen <johphi@gmail.com>
Published in v3.1.0. |
Hi @JEStaubach! Does that changes the way entries should be passed to Mustache? I included my json in a variable, but it seems now mustache doesn't find the array where values are stored to be substituted in the template. I tried doing {{#variable.arrayName}} But that didn't work. Thank you!! |
Allows functions to be passed in views by allowing javascript files instead of only JSON files.