Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the CLI to use JavaScript views when the project has ES6 modules enabled. #733

Merged
merged 1 commit into from
Dec 30, 2019

Conversation

eobrain
Copy link
Contributor

@eobrain eobrain commented Dec 30, 2019

Fix #732 by allowing CLI JavaScript views to have the .cjs suffix.

@phillipj phillipj merged commit aaaa94f into janl:master Dec 30, 2019
@phillipj
Copy link
Collaborator

Thanks a lot for getting .cjs supported both in the CLI and in the test suite in general.

v3.2.1 just got published to npm 🚀 Happy new years!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use JavaScript view from CLI when project has "type": "module"
2 participants