Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: janl/mustache.js Loading
base: v2.3.0
Choose a base ref
...
head repository: janl/mustache.js Loading
compare: v2.3.1
Choose a head ref
  • 11 commits
  • 11 files changed
  • 6 contributors

Commits on Jun 11, 2017

  1. Configuration menu
    Copy the full SHA
    2465398 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2017

  1. Configuration menu
    Copy the full SHA
    198a565 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #643 from raymond-lam/issue617

    Writer.prototype.parse to cache by tags in addition to template string
    dasilvacontin committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    b283da5 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2018

  1. Configuration menu
    Copy the full SHA
    3fddfb1 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2018

  1. Readme: Mustache.parse returns an array of Tokens (#657)

    In the README the return type for Mustache.parse is listed as a String. It's actually an array of Tokens.
    bbrooks authored and phillipj committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    85a2c2d View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2018

  1. fix bug: cache actually not working (#664)

    Resolve issue #663 and add test.
    Ashinoko authored and phillipj committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    28ca619 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2018

  1. Install release tools with npm rather than via pre-commit hook (#666)

    Previously mocha, uglifyjs and jshint used when publishing a new version were ensured / installed by `Rakefile` via the pre-commit git hook. Those modules were automatically installed globally if not present in `$PATH`.
    
    Installing modules globally has one particular downside that we should avoid: we can't ensure developers publishing new mustache.js versions have the same version of these 3rd party modules installed.
    
    If instead we make these modules local dev dependencies, we can ensure which versions are installed, and we make 3rd party dependencies explicit by listing them in `package.json`, rather than in `Rakefile`.
    phillipj committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    0a9999a View commit details
    Browse the repository at this point in the history
  2. Fix browser test suite by using Node.js 6 (#667)

    For a long time we've struggled getting the browser test suite to run
    on sauce labs. Those tests were running on Node.js 4 which is getting
    quite old.
    
    In a trial-n-error effort, I tried adding Node.js 6 as one of the
    versions to run on Travis CI, and at the same time ensure the browsers
    tests were run on that version instead of Node.js 4 -- voila the suite
    passed right away.
    
    It therefore seemed like the issues we were seeing had to do with us
    running those tests via Node.js 4.
    
    For a long time, we've been installing npm v2.x before running tests
    on Travis CI across all Node.js versions.
    
    While doing some testing today, I observed that we were able to install
    dependencies and run all tests just fine on all Node.js versions, except
    for v0.8. Therefore ensure we only force an install of npm v2.x when
    running tests on Node.js 0.8, and keep the installed npm version as is
    for all other Node.js versions.
    phillipj committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    5bbe25e View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2018

  1. Use ngrok rather than localtunnel when running browser tests (#668)

    These changes makes zuul use ngrok for exposing itself to the outside world, rather than the default localtunnel implementation. That's because we've had quite a lot of issues with flakyness which seems to be related to localtunnel, e.g.:
    
    ```
    - starting: <internet explorer 9 on Windows 2008>
    events.js:160
          throw er; // Unhandled 'error' event
          ^
    Error: connection refused: localtunnel.me:44896 (check your firewall settings)
        at Socket.<anonymous> (/home/travis/build/janl/mustache.js/node_modules/localtunnel/client.js:84:32)
        at emitOne (events.js:96:13)
        at Socket.emit (events.js:188:7)
        at emitErrorNT (net.js:1290:8)
        at _combinedTickCallback (internal/process/next_tick.js:80:11)
        at process._tickCallback (internal/process/next_tick.js:104:9)
    ```
    
    I thought this was fixed by [using Node.js 6 instead of Node.js 4](#667), but sadly that was not the case as it re-appeared with Node.js 6 as well.
    
    Had to use a [custom version of zuul-ngrok](https://github.com/rase-/zuul-ngrok/pull/12) which contains a newer version of ngrok. The dependency used by the upstream module threw an error when running on my computer, the updated version worked as a charm though. We should change to using the upstream module as soon as the PR with that ngrok version bump lands.
    
    Set `concurrency: 1` otherwise ngrok would fail and make IE11 tests stall forever because of too many connections being made within a short time period. I've notice it can take quite some time (20+ minutes) to get all the tests through as it seems ngrok still seems to throttle the connections somehow, but the important thing is getting these tests to work.
    phillipj committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    e443ada View commit details
    Browse the repository at this point in the history
  2. Fix Rakefile by deleting refs to removed install tasks

    Previously when replacing dependency installation with `npm` rather than
    `rake`, there were still install task references found in `Rakefile`
    which should have been removed as well.
    
    ```
    $ npm version patch
    v2.3.1
    
    ...
    
    npm ERR! > minifying `mustache.js`...
    npm ERR! rake aborted!
    npm ERR! Don't know how to build task 'install_uglify'
    ```
    
    Those `install_*` tasks does not exist anymore, as installing those
    dependencies are done with npm now.
    
    Refs #666
    phillipj committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    2659301 View commit details
    Browse the repository at this point in the history
  3. 🚢 bump to version 2.3.1

    phillipj committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    9e8035d View commit details
    Browse the repository at this point in the history
Loading