-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Comparing changes
Open a pull request
base repository: janl/mustache.js
base: v3.0.1
head repository: janl/mustache.js
compare: v3.0.2
- 15 commits
- 75 files changed
- 5 contributors
Commits on Jun 8, 2019
-
Updated Beard Competition URL in README.md (#699)
changed beard competition wiki link to the new link as the route has been changed.
Configuration menu - View commit details
-
Copy full SHA for 639c94f - Browse repository at this point
Copy the full SHA 639c94fView commit details
Commits on Jun 10, 2019
-
Cut official support for Node.js 0.8 by not running tests on it anymo…
…re (#700) Primarily because it's very painful to install 3rd party packages in the test phase of our CI runs, because many of them requires at least Node.js 0.10 or even higher. Therefore getting the test suite to run when using Node.js 0.8 is far from trivial, and the benefit of ensure Node.js 0.8 support these days is not obvious because it should really not be used knowing that it has reached end-of-life a long time ago. Worth noting there's no breaking changes in this commit to mustache.js's source code, we just don't want to struggle getting our CI to care about it. In other words, it should still be possible to use Node.js 0.8, but we won't care much making sure it keeps working going forward.
Configuration menu - View commit details
-
Copy full SHA for fe06a16 - Browse repository at this point
Copy the full SHA fe06a16View commit details
Commits on Jun 26, 2019
-
Run tests on Node.js 8 as well
Also tried with Node.js 10 and 12, but some CLI tests explodes so awaiting a fix for that before adding those versions explicitly.
Configuration menu - View commit details
-
Copy full SHA for 78eb820 - Browse repository at this point
Copy the full SHA 78eb820View commit details -
cli-test: fs.unlink → fs.unlinkSync to fix test failure on Node 10 (#701
) Fixes this failure: 1) Mustache CLI without partials writes rendered template into the file specified by the third argument: Uncaught TypeError [ERR_INVALID_CALLBACK]: Callback must be a function at makeCallback (fs.js:136:11) at Object.unlink (fs.js:943:14) at test/cli-test.js:86:12 at ChildProcess.exithandler (child_process.js:285:7) at maybeClose (internal/child_process.js:982:16) at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5) Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Configuration menu - View commit details
-
Copy full SHA for 932ad33 - Browse repository at this point
Copy the full SHA 932ad33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11ac71a - Browse repository at this point
Copy the full SHA 11ac71aView commit details
Commits on Aug 1, 2019
-
Start linting all test/ files as part of test script (#704)
In an effort of ensuring consistent code style in test files as with the "production" source code, we should run eslint as part of the `$ npm test` script as well. Most of the related fixes was done by `eslint` using the `--fix` argument. Only special configuration tweaks for tests compared to the other source code, is to allow functions declaration without names. The rationale for allowing that in tests, is that the important reason we have them in the source code (proper stacktraces) aren't as important in test files.
Configuration menu - View commit details
-
Copy full SHA for bb700c5 - Browse repository at this point
Copy the full SHA bb700c5View commit details -
Try a basic GitHub Actions workflow
As a means of seeing how GitHub Actions work compared to Travis CI, these changes creates a so-called workflow that runs `$ npm test` upon every `$ git push` to the repository.
Configuration menu - View commit details
-
Copy full SHA for d0290c4 - Browse repository at this point
Copy the full SHA d0290c4View commit details -
Install deps as part of GitHub Actions workflow
..forgot to install dependencies before executing `$ npm test` which obviously exploded due to the fact that `eslint` and friends weren't available.
Configuration menu - View commit details
-
Copy full SHA for 930a485 - Browse repository at this point
Copy the full SHA 930a485View commit details -
Install deps *before* tests in Actions workflow
While creating the `$ npm install` step in the GitHub Actions workflow, I forgot to state the fact that the `$ npm test` step "needs" the install deps step to have successfully run first.
Configuration menu - View commit details
-
Copy full SHA for 1a244cb - Browse repository at this point
Copy the full SHA 1a244cbView commit details
Commits on Aug 21, 2019
-
As referenced in this issue: #562 Partials aren't indented as per the spec: https://github.com/mustache/spec/blob/master/specs/partials.yml#L13-L15 This adds indentation tracking for partials and applies them to the first instance of a partial on a line (to not indent inline partials which would violate a different part of the spec).
Configuration menu - View commit details
-
Copy full SHA for cadf571 - Browse repository at this point
Copy the full SHA cadf571View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69e2bf3 - Browse repository at this point
Copy the full SHA 69e2bf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c4187a - Browse repository at this point
Copy the full SHA 1c4187aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc8eb5d - Browse repository at this point
Copy the full SHA fc8eb5dView commit details -
Delete old GitHub Actions workflow file
As the hottest of the press features of GitHub Actions requires using YAML rather than HCL.
Configuration menu - View commit details
-
Copy full SHA for 619c928 - Browse repository at this point
Copy the full SHA 619c928View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c3608b - Browse repository at this point
Copy the full SHA 6c3608bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.0.1...v3.0.2